peteshow icon indicating copy to clipboard operation
peteshow copied to clipboard

Expose Faker again

Open esambo opened this issue 10 years ago • 7 comments

Faker used to be globally exposed which allowed the consuming Rails app to do things like: Faker.Address.streetAddress() But the introduction of gulp in #2 stopped doing this which now causes the error: Uncaught ReferenceError: Faker is not defined and stops Peteshow from loading.

I wouldn't mind if Faker would be scoped within Peteshow, but such a breaking change should probably be mentioned in a Changelog.md file

Affected apps based on a GitHub search are:

esambo avatar Dec 31 '14 20:12 esambo

But why can't we make Faker globally accessible? It's a public library and not an implementation detail. It is a dependency. It is not modified by Faker and therefore probably should NOT live within the Peteshow namespace!

esambo avatar Dec 31 '14 22:12 esambo

It wasn't on purpose. When Kevin did the gulp changeover, he broke that on accident.

I'll fix it shortly.

brousalis avatar Jan 01 '15 17:01 brousalis

There seem to be some other errors too when trying to fill out a form with Peteshow

esambo avatar Jan 02 '15 17:01 esambo

I think its pretty safe to say Kevin's gulp implementation is broken and master is dirty. I'll revert everything.

However I never released his changes to the gem itself, so the gem is still stable.

brousalis avatar Jan 02 '15 17:01 brousalis

Yes, 0.8.6 (referencing ref 1d93e3f) works, and rebasing #2 onto that last commit before gulp works fine

esambo avatar Jan 02 '15 17:01 esambo

Hey!

itsthatguy avatar Jan 05 '15 17:01 itsthatguy

Digging into all of this now

itsthatguy avatar Jan 05 '15 17:01 itsthatguy