Daniel Brotsky

Results 93 comments of Daniel Brotsky

Hey there, I've had a chance to look over the code now, and I think maybe if we change approach this can be done much more simply (and with a...

Hi @wiimmers my fingers are crossed that the "big changes" for your family are good ones! Yes, you and I agree: I would like to close this PR and then...

Thanks for your thoughtful comments; they make a lot of sense. I absolutely agree that keeping things simple to begin with is the way to go. It doesn't need to...

Wrt using dbus-secret-service with tokio and zbus: I have tested that thoroughly and there's no issue there. I'd really like to keep the footprint as light as possible and I...

Don't worry about the test failures until we have unit tests and docs. Then, if necessary, I'll pull it and look at it.

OK, I've updated docs and tweaked a few things. Please take a look and try it out and let me know if you think we are ready to pull this.

Hi Andrej, thanks for pointing out this issue. I completely agree that it would be great to expose these, but I believe doing so in a platform-specific way might be...

Yes, the approach of using "reserved" attributes for values such as `kSecAttrAccessible` makes a lot of sense to me, and fits well with the existing special meaning of attributes on...

WRT platform specificity of attributes: The way this works currently is that attributes are interpreted by the credential store (aka keystore), not by the top-level code. Thus they are not...

I am about to split this crate into several crates: - keyring-core (the cross platform library parts of this crate) - apple-native-keyring (the apple-native credential store implementations) - windows-native-keyring (the...