Hydrocraft icon indicating copy to clipboard operation
Hydrocraft copied to clipboard

Build 41 Beta1 Error Spam

Open Lithorn opened this issue 5 years ago • 8 comments

Currently if you open the craft menu and select any of the forged weapons the log will be spammed with errors despite it displaying correctly. The FPS will dwindle and it will recover if you click something else that isnt a forged weapon. There are other items in hydrocraft that do this but most notable are every single forged weapon.

This is what is reported.

[30-11-19 21:11:54.195] LOG : General, 1575166314195> STACK TRACE. [30-11-19 21:11:54.202] LOG : General, 1575166314202> -----------------------------------------. [30-11-19 21:11:54.209] LOG : General, 1575166314209> Callframe at: getRequiredSkills. [30-11-19 21:11:54.216] LOG : General, 1575166314216> function: render -- file: ISCraftingUI.lua line # 632. [30-11-19 21:11:54.223] ERROR: General, 1575166314223> ExceptionLogger.logException> Exception thrown java.lang.reflect.InvocationTargetException at GeneratedMethodAccessor607.invoke.. [30-11-19 21:11:54.230] ERROR: General, 1575166314230> DebugLogStream.printException> Stack trace:.

Lithorn avatar Dec 01 '19 02:12 Lithorn

Hey, Had this myself in my won small mod. Can You tell here what requirements are to craft example thing and especially what skills are need? I think, since pz41 have changes around blade maintenance skills, it's throwing exception as needed skill does not exist. PS - this is just a hunch.

ttr avatar Jan 04 '20 11:01 ttr

OK, this will be related to skills changes - dig up my comment on steam and log trace and it's same https://pastebin.com/EUXVX1dU

ttr avatar Jan 05 '20 21:01 ttr

i think a temporary fix for this would be to just delete the requirement in every recipe in the mod files

Timer004 avatar Jan 07 '20 16:01 Timer004

I would be against that. If this would be bug in stable version than maybe as a quick fix this would be viable option, but this is beta. Removing requirements will change balance of game (as small new issue) and what more can lead to not getting this fix at all (simple 'oh, we forgot'). If author will not fox this and I'll have weekend off, I'll try to create pr with new definitions (no promises with 5mo old kid in house).

ttr avatar Jan 07 '20 18:01 ttr

just replace the requirement for blunt maintenance with the new maintenance skill and grind for it 10 hours like a boss (or just hit the tree for 10 hours)

i myself replaced anything requiring that with electronics skill cuz why not its even harder to get then maintenance

Timer004 avatar Jan 07 '20 22:01 Timer004

just replace the requirement for blunt maintenance with the new maintenance skill and grind for it 10 hours like a boss (or just hit the tree for 10 hours)

then you're free to open PR here and contribute back (just with proper skill name)

ttr avatar Jan 10 '20 10:01 ttr

i can also replace all the base. things as they are no longer the correct form base items are suposed to be written in but idk if i have time rn

u literaly just open notepad click replace find the bluntmaintenace and tell it to replace it with maintenace

Timer004 avatar Jan 12 '20 22:01 Timer004

This should be it https://github.com/DemolitionDerby/Hydrocraft/pull/74 (and yes, only today had spare time)

ttr avatar Apr 05 '20 18:04 ttr