remix-routers
remix-routers copied to clipboard
brophdawg11
Solid adapter
This pr adds support for solid.js adapter for @remix_run/router package with all tests passing.
In some cases there are differences between react-router and vue implementation, for example Link component in vue does not support relative-path but Link in react does. I have implemented similar to vue only (i.e solid Link also does not support relative-path ). Let me know If i need change that too.
Let me know if anything more needs to be done
This is awesome - thank you for working on this!! I will try to take a look at this in the coming week or so as I get back into the swing of things post-holiday 👍
Great to hear that, hope you had fun on your holidays.
You can go through the pr in your suitable time.
Anyways, I think I could make few more improvements to pr, mostly combining all files in components folder to one file and others.
I will make those changes after your feedback
This looks great! The app looks right to me - I haven't written any SolidJS before so I can't speak much to the specifics but overall the approach and touchpoints with the @remix-run/router look solid to me (pun very much intended 😂 ).
I have implemented similar to vue only (i.e solid Link also does not support relative-path)
Yeah I would ignore relative routing and any basename stuff for now. We're hopefully moving all that logic into the @remix-run/router at some point (see https://github.com/remix-run/react-router/discussions/9588), so once we do that Vue/Svelte/Solid can all just inherit it automatically.
I'll go through and leave any comments, but generally I'd say feel free to go through and do any cleanup you'd like. Once that's done we can get it merged to main. Then I'm not sure what's involved in bundling/packaing up a SolidJS npm package - so I'll let you handle that part as well if that's cool with you?
Thanks for the feedback. I will work on those over the week and update the pr
Sorry, I got busy with some other work. I will try to finish this by week
