eufy-security-ws icon indicating copy to clipboard operation
eufy-security-ws copied to clipboard

[Bug]: The audio is not downloaded when sending 'device.start_download'.

Open tyware opened this issue 3 years ago • 1 comments
trafficstars

Version

0.9.4

Node version

16.3.0

Operating System type

Linux

Operating system version

Raspberry Pi 4B

Describe the bug

For command 'device.start_download', only video data is downloaded, the audio part is missing. After tracing the code, found the bug in src/lib/forward.ts, under the audiostream.on(...) the below line needs to be changed, From: this.clients.clients.filter((cl) => cl.receiveLivestream[serialNumber] === true && cl.isConnected) To: this.clients.clients.filter((cl) => cl.isConnected)

cl.receiveLivestream[serialNumber] is undefined for audio data.

My device is Eufy solo 2K (8441). the changed codes is working well.

To reproduce

try it.

Screenshots & Logfiles

No response

Additional context

No response

tyware avatar Aug 16 '22 23:08 tyware

This one may solve the issue #101 as well.

tyware avatar Aug 16 '22 23:08 tyware