commonregex-improved icon indicating copy to clipboard operation
commonregex-improved copied to clipboard
verified publisher icon brootware

Improve code readability

Open luizvbo opened this issue 2 years ago • 3 comments

I saw that there are very long lines in the code, so I set the max-line-lengh to 88 for flake8 and split the long regex strings.

l also added an "r" to the regex strings to avoid the DeprecationWarning: invalid escape sequence warning appearing when test_crim.py runs.

luizvbo avatar Jan 27 '23 08:01 luizvbo

Hi @luizvbo , the PR looks good. May I know why you closed it?

brootware avatar Jan 28 '23 01:01 brootware

Hi @brootware. I am currently using the package in my work and I decided that I need to do bigger changes to the code. Hence, I decided to make a fork of your repo and work from there instead. Few free to apply the PR though. I'm going to reopen it.

luizvbo avatar Jan 30 '23 07:01 luizvbo

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 30 '23 07:01 sonarqubecloud[bot]