airborne icon indicating copy to clipboard operation
airborne copied to clipboard

added the ability to pass advanced options to the request (like timeout…)

Open bafio opened this issue 8 years ago • 8 comments

added the ability to pass advanced options to the request (like timeout…)

bafio avatar Nov 21 '16 15:11 bafio

Coverage Status

Coverage decreased (-0.1%) to 98.861% when pulling af2b7c19716759a1dfed38d586e5a30e07d0cc2f on bafio:master into 55311accd13abbe3a533429fdf80a66cb31dd84f on brooklynDev:master.

coveralls avatar Nov 21 '16 15:11 coveralls

@bafio Is there an eta on when this will be merged/available?

rdhanoa avatar Apr 04 '17 22:04 rdhanoa

@rdhanoa I have no write privileges on this repo, @brooklynDev may be able to answer your question

bafio avatar Apr 04 '17 23:04 bafio

@brooklynDev Are there any chance that this PR will be accepted?

AndreasBomholtz avatar May 23 '19 13:05 AndreasBomholtz

@mycargus thoughts?

sethpollack avatar May 23 '19 14:05 sethpollack

I'll take a look. I like the idea for sure.

mycargus avatar May 25 '19 00:05 mycargus

finally diving into this today. Sorry for the delay.

mycargus avatar May 31 '19 14:05 mycargus

+1 This looks good to me, though I think some additional integration tests would be nice to verify the options work as expected and aren't just sent to the RestClient library. Not a blocker though in my opinion.

Looks like we just have some merge conflicts to iron out.

mycargus avatar May 31 '19 14:05 mycargus