airborne icon indicating copy to clipboard operation
airborne copied to clipboard

Using the DELETE functionality is now only possible with supplied body

Open stefan-kolb opened this issue 9 years ago • 1 comments

Introduced by d8a515e0c0887447653fb87424f5b3283169de6d.

-  def delete(url, headers = nil)
-    @response = make_request(:delete, url, headers: headers)
+  def delete(url, delete_body = nil, headers = nil)
+    @response = make_request(:delete, url, body: delete_body, headers: headers)
    end

Is this really wanted? Shouldn't there be an option to only supply headers as with get requests? Btw, this change took me hours to find out why my headers were not passed correctly/missing as with v0.1 (also motivates https://github.com/brooklynDev/airborne/issues/104).

stefan-kolb avatar May 18 '16 13:05 stefan-kolb

This was driving me nuts as well.

MariusJorgensen avatar Sep 13 '17 11:09 MariusJorgensen