dbt_artifacts icon indicating copy to clipboard operation
dbt_artifacts copied to clipboard

[Bug]: Fix linting action

Open glsdown opened this issue 2 years ago • 1 comments

Overview

Currently there are inconsistencies in the SQL scripts styles used (e.g. trailing vs leading commas). It's unclear if this is because the check was ignored when the files were amended, or if the check isn't working.

How to reproduce

  • Example leading commas - models/dim_dbt__current_models.sql
  • Example trailing commas - models/staging/stg_dbt__models.sql

Expected behaviour

All files to have consistent formatting.

Screenshots

Environment

Results of running dbt --version:

# Add the results here

Please paste the contents of your packages.yml file here:

packages:
  ...

glsdown avatar Sep 18 '23 15:09 glsdown

I can see the inconsistencies. I propose a giant PR that switches everything to leading commas. I'd be up for it!

poloaraujo avatar Sep 28 '23 18:09 poloaraujo