add more fields to tests

[patkearns10]

Opening this to replace #177

Adding a few Test dimensions that could make analysis a bit easier.

short_name= shorter version of the test name, example. 'unique', instead of long name unique_my_first_model_col test_type= 'singular' or 'generic' test_severity_config= 'ERROR' or 'WARN' model_refs= short name of model dependencies source_refs= short name of src dependencies

[patkearns10]

@NiallRees @jaypeedevlin - opening this to factor in the new changes from #188 . Worth noting I have not tested this since I initially wrote it and only tested on snowflake at the time.

[NiallRees]

Hi @patkearns10, I ran the integration tests and it looks like there are a couple of small issues. Let me know if I can help.

[patkearns10]

Thanks Nial, I'll take a look on my end this week!

On Tue, Oct 4, 2022 at 3:48 AM Niall Woodward @.***> wrote:

Hi @patkearns10 https://github.com/patkearns10, I ran the integration tests and it looks like there are a couple of small issues. Let me know if I can help.

— Reply to this email directly, view it on GitHub https://github.com/brooklyn-data/dbt_artifacts/pull/213#issuecomment-1266539939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJ6G3VWIGZXRLXWDRXE3F3WBPOM7ANCNFSM6AAAAAAQ2JRSQQ . You are receiving this because you were mentioned.Message ID: @.***>

--

Pat Kearns Sr. Analytics Engineer

P: +61 477 539 852

www.getdbt.com http://www.getdbt.com/?utm_medium=email&utm_source=opensense

http://www.getdbt.com/?utm_medium=email&utm_source=opensenseConnect with us:

https://github.com/dbt-labs/dbt http://linkedin.com/company/dbtlabs/ https://twitter.com/dbt_labs https://www.youtube.com/c/dbt-labs

https://blog.getdbt.com/of-the-community-by-the-community-for-the-community/?utm_medium=email&utm_source=opensense&utm_campaign=q3-2021_brand-launch

[patkearns10]

Came back to this! I was having issues with a helper macro, so had to nix that, at the expense of being less DRY. But now it works, tested locally in Snowflake!

[patkearns10]

@NiallRees @jaypeedevlin - Does someone on your end need to kick off these tests?

[glsdown]

HI @patkearns10 . I'm really sorry about how long is has taken someone to get back to you. I'm afraid your PR got caught up in a bit of limbo.

The changes that you have suggested look really useful and I'd love to be able to get this into the project. Please let me know if you still have appetite to work on this? I completely understand if you are no longer interested though, and I would be happy to bring it up to date with the current repo and make any required changes to ensure it works as expected instead.

One change that would need to happen once it's up to date is that the new fields all need to be added to the bottom of the lists in the upload_ macros as well as the sources.tests table. This is to ensure backwards compatibility with older versions. Let me know if this doesn't make sense and I'll happily demonstrate via a review comment instead.

[patkearns10]

Hi @glsdown , it has been a while since I have thought about this. A review comment would be extremely helpful :)