Robert Kieffer issues

Results 43 issues of


                                            Robert Kieffer

onChange event should not fire for programmatic changes

Start with a Component that updates props state asynchronously when form values change, something like this: ``` function MyFormThing(props) { function handleChange(formState, isChanged) { console.log('isChanged:', isChanged) // (trigger async action...

pull request wanted

Incorrect line numbers in stack traces

When running with this loader, stack trace errors are incorrect. ## Recipe Create a basic test file that has a comment in it, like so: ``` $ cat test.ts //...

"pair[kSend] is not a function" error after upgrading from 2.7.1 -> 2.9.0

'Just upgraded from `2.7.1` to latest (`2.9.0`) and am now getting the following when trying to set up the WebSocketPair in my durable object: ``` TypeError: pair[kSend] is not a...

question

Durable object instance not evicted when blockConcurrencyWhile() callback throws

**Problem** Chatting with @bretthoerner in Discord about how to force a DO to be evicted, he suggested throwing from within the `blockConcurrencyWhile()` callback. While this works in production, it does...

behaviour mismatch

default array value for emit() args

Fixes bug where calling `myObservable.emit('some-event')` (with no 2nd argument) throws a "TypeError: args is not iterable (cannot read property undefined)" error.

Throw when reading past end of array

Putting this up as an (untested) fix for #42. This isn't duck-typing but, instead, enforces the known array length. Has the additional benefit of catching other cases where the same...

vue-template-compiler `"vue": "file:../.."` devDependency breaks installs in yarn "workspaces" environments.

### Version 2.7.14 ### Reproduction link https://github.com/vuejs/vue/blob/dev/packages/vue-template-compiler/package.json#L29 ### Steps to reproduce * Check out [the package.json file](https://github.com/vuejs/vue/blob/dev/packages/vue-template-compiler/package.json#L29) * Notice the "`file:../..`" version string. (Apologies for not providing an actual SSCCE...

Robert Kieffer