brut.apktool icon indicating copy to clipboard operation
brut.apktool copied to clipboard

Why not close the file in the end of brut.androlib.src.SmaliBuilder.buildFile(..)?

Open mcai opened this issue 13 years ago • 0 comments

Hi Brutall,

Thanks for your great job.

I've encountered the java.io.FileNotFoundException (Too many open files) when I use apktool to build lots of smali files for a large apk file in a resource restricted environment.

The real problem is:

Why not close the file (input stream) in the end of brut.androlib.src.SmaliBuilder.buildFile(..)? If there are lots of smali files to build, not closing the opened files will cause java.io.FileNotFoundException (Too many open files) in the middle of SmaliBuilder.build(..).

Looking forward to your reply.

Thanks.

Yours sincerely,

Min Cai

mcai avatar Nov 19 '11 07:11 mcai