iproute2mac icon indicating copy to clipboard operation
iproute2mac copied to clipboard

Color option is missing

Open ThangCZ opened this issue 6 years ago • 6 comments

The -c, -color option is missing. It's an essential part of iproute2. We should definitely support it!

ThangCZ avatar May 29 '18 08:05 ThangCZ

This would be great. At least at first, the -c and -color options could be ignored such that aliases don't break.

naggie avatar May 30 '18 09:05 naggie

Ignoring shouldn't be a problem to maintain cli compatibility. Will be likely in next release. Full feature implementation however seems a bit tricky, I will have to review the underlying commands.

brona avatar Jun 04 '18 18:06 brona

Color option is now being ignored for script compatibility, keeping the FR open to implement it for real.

brona avatar Aug 01 '24 11:08 brona

Thanks @brona !

naggie avatar Aug 01 '24 13:08 naggie

Color option is now being ignored for script compatibility, keeping the FR open to implement it for real.

Are you sure? I'm still seeing an error with latest version:

$ ip -c a
Option "-c" is unknown, try "ip help".
$ ip -V
iproute2mac, v1.5.2

silverwind avatar Aug 19 '24 14:08 silverwind

Color option is now being ignored for script compatibility, keeping the FR open to implement it for real.

Are you sure? I'm still seeing an error with latest version:

$ ip -c a
Option "-c" is unknown, try "ip help".
$ ip -V
iproute2mac, v1.5.2

Thank you for the report, fixied in v1.5.3. -color=never was already being parsed correctly (and ignored), however there was a bug for -c. You can track the release to Homebrew on https://github.com/Homebrew/homebrew-core/pull/181685

brona avatar Aug 19 '24 15:08 brona