vue-moment icon indicating copy to clipboard operation
vue-moment copied to clipboard

Add support Vue 2|3, refactoring code

Open rah-emil opened this issue 2 years ago • 6 comments

I don't think it's worth keeping the old syntax with filters. Even the Vue developers don't recommend doing this either.

I propose a solution that contains support for two versions of Vue, which also passes all the tests you wrote (only, I changed the main moment prototype, it now does not contain the $ symbol).

rah-emil avatar May 12 '22 11:05 rah-emil

I also updated the README

rah-emil avatar May 12 '22 11:05 rah-emil

Nice job! Really good work 👍

AndyKuhorenko avatar May 12 '22 11:05 AndyKuhorenko

Commit Explanations: 0ddf4ef 78875a7 6d0f2d0

I need this plugin for a project on Vue 3, and there is no time to wait for the merge. I posted my version to myself, but made a revert of these changes for merging with you.😇

rah-emil avatar May 12 '22 12:05 rah-emil

I think this all makes sense to me, great work 👍 I think it would be wise to give this package a major package bump when we merge this in, to cover for the breaking changes.

BrockReece avatar May 16 '22 08:05 BrockReece

I think this all makes sense to me, great work 👍 I think it would be wise to give this package a major package bump when we merge this in, to cover for the breaking changes.

Thank you! Write what you need, I'm ready. I would love to be on the list of collaborators)

rah-emil avatar May 16 '22 08:05 rah-emil

Hi @BrockReece, do you think we can have this merged some time soonish?

hluz avatar Dec 28 '23 11:12 hluz