csshx icon indicating copy to clipboard operation
csshx copied to clipboard

Mojave

Open viratgohil opened this issue 7 years ago • 7 comments

viratgohil avatar Sep 25 '18 18:09 viratgohil

Not my code, credit to @pkovtuov https://github.com/brockgr/csshx/issues/94

viratgohil avatar Sep 25 '18 18:09 viratgohil

+1

thinker0 avatar Oct 01 '18 05:10 thinker0

This PR does work as advertised, although the two commits should be rebased/squished together, since the latter one un-does most of the changes in the former.

nisimond avatar Nov 30 '18 17:11 nisimond

Caveat: you need to set "System Preferences » Dock » Prefer tabs when opening documents" to "Manually" or this REALLY doesn't work anymore.

nisimond avatar Nov 30 '18 17:11 nisimond

I will try to take a look on this asap.

Saluts, Guillem

El 30 nov 2018, a las 18:45, Nicolas Simonds [email protected] escribió:

Caveat: you need to set "System Preferences » Dock » Prefer tabs when opening documents" to "Manually" or this REALLY doesn't work anymore.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brockgr/csshx/pull/97#issuecomment-443282827, or mute the thread https://github.com/notifications/unsubscribe-auth/ANrzAG9UUfiXYAYksM6q85bvOK3GPr3yks5u0W7MgaJpZM4W5OQA.

parera10 avatar Nov 30 '18 17:11 parera10

Whoops. I posted these reviews from the wrong account. Not that it makes much of a difference.

0xDEC0DE avatar Nov 30 '18 18:11 0xDEC0DE

Hi,

I've forked and merge them in my account: https://github.com/parera10?tab=repositories 2 repos:

  • the forked one
  • other with the homebrew Formula.

Regards

parera10 avatar Dec 27 '18 11:12 parera10