jQuery.YoutubeBackground icon indicating copy to clipboard operation
jQuery.YoutubeBackground copied to clipboard

resize bug regular videos

Open mamaretti opened this issue 7 years ago • 2 comments

Hi rochestb, thx for the nice script. there is an issue when using it with fitToBackground: false

you can see it when you resize the browser window. http://rochestb.github.io/jQuery.YoutubeBackground/

i changed (LINE 223) if (!self.options.fitToBackground) { container = self.$node; }

to if (!self.options.fitToBackground) { container = self.$node; return; }

to avoid resizing

mamaretti avatar May 08 '17 09:05 mamaretti

Hi @rochestb , any chance we can display the same for both fitToBackground: true and false when resizing? It's good if we can get middle part of the video in fitToBackground:True and better to apply the same to fitToBackground:False. Currently, when using container, it displays the left part of the video. It would be great if you add something to make it the same as fitToBakcground:true.

Sample: fitToBackground: true, nut

fitToBackground: false, nut2

Many thanks,

lyjen avatar Feb 05 '20 15:02 lyjen

Does someone want to open a PR for this? I don't really maintain this plugin anymore but can help get it on npm.

bento-n-box avatar Feb 09 '20 20:02 bento-n-box