Brian R. Murphy

[Bug][move-compiler] PackageLock is not held while running extended checks and modifying metadata

1

# 🐛 Bug Compiled bytecode output is apparently written by function save_to_disk. [https://github.com/aptos-labs/aptos-core/blob/211fcdaf1abfa01561cdab79ab00a68a5ec2[…]rty/move/tools/move-package/src/compilation/compiled_package.rs](https://github.com/aptos-labs/aptos-core/blob/211fcdaf1abfa01561cdab79ab00a68a5ec299de/third_party/move/tools/move-package/src/compilation/compiled_package.rs#L873) It is called from compile_package and compile_package_no_exit etc., here https://github.com/aptos-labs/aptos-core/blob/1a639a9cc3c21a447ce5031c6241a21ea6fb02ed/third_party/move/tools/move-package/src/lib.rs#L202, while holding a PackageLock. Then compile_package_no_exit is...

Add a warning for an unnecessary trailing semicolon in move-compiler-v2

5

## Description Add a warning for an unnecessary semicolon for compiler V2. Following V1 behavior, we warn about the semicolon only in the case that the preceding statement interrupts control...

[Bug][move-compiler-v2] `*&x` gets turned into `move x` in at least one case

1

# 🐛 Bug Compare test outputs: - third_party/move/move-compiler/tests/move_check/translated_ir_tests/move/signer/read_ref_transitive.exp - third_party/move/move-compiler-v2/tests/ability-check/v1-signer/read_ref_transitive.exp V2 seems to accept `*&x` as valid for a type without `copy` by turning it into a `move x`. Splitting...

[compiler-v2] Avoid infinite recursion showing types with receiver functions in presence of errors

2

## Description When displaying a "receiver function" type in the presence of errors, a type variable may be shown by showing the receiver function type, which includes the type variable...

[Bug][move-compiler-v2] move-model AST represents short-cut `||` and `&&` as simple Calls, check for potential errors

1

# 🐛 Bug I (Brian) implemented various optimizations on the movel-model AST without realizing that short-cutting `||` and `&&` haven't been lowered to more explicit control flow, but remain as...

[Bug][move-compiler-v2] Function-valued argument type error message is confusing

1

# 🐛 Bug ``` public inline fun pass_mut_ref(v: &mut vector, action: |&mut T|&mut T): &mut T { action(vector::borrow_mut(v, 0)) } public fun consume_mut_freeze() { let v = vector[1, 2, 3];...

# 🐛 Bug Compiler V1 catches some "missing ability `key`" errors which are missed by Compiler V2: - third_party/move/move-compiler/tests/move_check/typing/pack_constraint_not_satisfied.exp - third_party/move/move-compiler-v2/tests/ability-check/v1-typing/pack_constraint_not_satisfied.exp Reducing the test to try to eliminate error shadowing:...

[compiler-v2] add test cases for lambda

9

## Description Add a `/lambda/` test subdir for `move-compiler-v2`, and test it with `LAMBDA` experiments off (`.exp`) and on (`.lambda.exp`). ## How Has This Been Tested? This is just a...

add parser code for lambda types

3

## Description Extend syntax - lambda expression: `|args| body has copy, store` - function types: `|T1, T2| T3: copy+store` - arbitrary function calls: - `(expr)(args, ...)` - `func(args, ...)` -...