Brian R. Murphy

>  ? I don't understand the question here. If I missed this one before, it's now included in this PR.

I'm reducing priority, since it's ok to ship with this, as long as it still works.

There's an issue to track keeping inline functions: https://github.com/aptos-labs/aptos-core/issues/12041

We should track getting it in CI. But with the script we can call it done, maybe.

Done.

Can we add a small test case or 2 showing critical edges and what happens with them? Some of the break/continue loop tests probably should show critical edges.

The diff is required because we don't have good processes. If test changes are required to exhibit the functionality we want, then we should add a new (modified) test that...

> This does not work. Those left tests make no sense in v2 because they produce random results. All the more reason to include them at the time the test...

Are you saying that you have expect that it will be fixed, so this bug should be closed?

Thanks. We can perhaps solve this by rewriting `ExpData::rewrite_exp_and_pattern` to use an expression stack instead of recursion. But that will either involve terrible macros (as V1 had) or some major...