Brian R. Murphy

Results 66 comments of Brian R. Murphy

This approach is now illustrated in https://github.com/aptos-labs/aptos-core/pull/12944, but without a separate function yet since I want to reorganize it based on https://github.com/aptos-labs/aptos-core/pull/12943 once one of them gets committed.

@JoshLind might know something about the files.

This was closed as stale. If it's now fixed, perhaps you can close it again, Victor.

Seems to have been fixed here: https://github.com/aptos-labs/aptos-core/pull/8789

I note that there is a --skip-fetch-latest-git-deps flag which you can use in case of poor network connection.

No, `__update_iter_flag` should be renamed to something not accepted as a user symbol, such as `$update_iter_flag`.

vineeth might be interested. maybe standardizing the artificial sym names would be a good idea.

I priorized this as High because this is V1 and should be fixed before any release of this code, lest users start relying on it.

This vaguely resembles a "critical edge" problem, and it might help to just pre-process the CFG to insert empty blocks on every critical edge. Then again, if you're only checking...