Neuron icon indicating copy to clipboard operation
Neuron copied to clipboard

Having Blizzard Actionbars hidden in settings prevents ExtraActionButton from showing

Open Ketrel opened this issue 3 years ago • 4 comments

How to reproduce / Issue description:**

  1. Ensure that in the "Display the Blizzard UI" settings ActionBar is unchecked and Extra Action Bar is checked

Results: Extra Action Button is NOT displayed
Expected Results: Extra Action Button is displayed

Technical info:

  • Addon Version: commit 6d8a8c3
  • Client: Retail
  • Client Patch Version: 10.0.2

Additional context:

I've traced it to line 87 in Neuron-DisableBlizzardUI.lua which runs when Blizzard ActionBars are set to be hidden

ActionBarController:UnregisterAllEvents()  

The comment says that's to avoid potential for taints, but it unfortunately looks like it also prevents whatever event would show the blizzard extra action button.

Ketrel avatar Nov 28 '22 18:11 Ketrel

i haven't figured out a good place to test the extra action button (or the zone buttons)

this isn't happening at a place that would be easy for me to test is it?

ylixir avatar Nov 28 '22 20:11 ylixir

Suramar City will activate both the Extra Button and the zone ability button

brittyazel avatar Nov 28 '22 20:11 brittyazel

I used Suramar for my testing to isolate the line causing the issue.

For zone, Draenor Garrison works as that's just zone, not extra.

Ketrel avatar Nov 28 '22 22:11 Ketrel

add vehicle exit button to this list as well

ylixir avatar Dec 03 '22 16:12 ylixir