zui icon indicating copy to clipboard operation
zui copied to clipboard

Right-click menu not appearing on Windows/Linux

Open philrz opened this issue 2 years ago • 1 comments

Repro is with GA Zui v1.0.1.

A community user reported the following in a Slack message and provided the attached video. I've reproduced the same behavior on Windows and also confirmed that it does not seem to repro on macOS. 🤔 In their own words:

Right clicking on the domain name may result in the context menu not appearing. A work around is to select the ‘inspector’ or clicking the corner of the table. This was was on a Windows machine : )

https://user-images.githubusercontent.com/5934157/230795018-d66d8bf8-2404-4b80-82f5-80097434b09c.mp4

philrz avatar Apr 09 '23 20:04 philrz

Another community user (running Zui Insiders on Windows 10) reported on a Slack thread that they bumped into what looks like another instance this issue. In their own words:

is this expected? my right click only works in table view if I right click on white space. If there is a value underneath the menu just blinks This is win 10 zui_insiders_right_click

I first tried to reproduce the problem with Zui Insiders 1.3.1-4 on macOS using attached data input.csv and found it would not repro. I then tried on Windows 10 and found it did repro. Finally, I tried on Linux and found it did repro there, as shown in the attached video. Notice how sometimes after I right-click we can briefly see the ghostly outline of the menu.

https://github.com/brimdata/zui/assets/5934157/3c02c246-fb9c-4679-a307-6a6178610e26

The "it repros on Windows but not on macOS" symptom rang a bell and I found this existing issue. Since this is the second community user to independently bump into this, I'm boosting the priority in hopes it can be addressed before our next GA release.

philrz avatar Oct 05 '23 19:10 philrz

Verified in Zui commit 9f091b6.

@jameskerr recently picked up this issue with intent to fix it, only to find that he could no longer reproduce it on Windows. Since it also repro'ed on Linux in the past, I looked into it further there and via binary search have confirmed that it started working at commit 9f091b6, which is associated with the changes in #2895. The attached video confirms that right-clicks on the values now bring up the menu as well, not just when clicking on white space. The "rings" effect appears with each right-click.

https://github.com/brimdata/zui/assets/5934157/fcbfff76-a938-40a7-acbf-5bc4cdc6ef9a

Thanks @jameskerr!

philrz avatar Jul 02 '24 17:07 philrz