zui icon indicating copy to clipboard operation
zui copied to clipboard

Buggy multi-select pool delete operations

Open philrz opened this issue 1 year ago • 1 comments

Repro is with Brim commit b7ee21a which uses Zed commit 6737ae9.

As shown in the attached video, it's currently possible to Shift-Click to multi-select many items in the pools list. This may give users the impression that a selection in the right-click menu will now operate on the multiple selected pools, but this is currently not the case.

For instance, if a regular Delete is selected, only the pool that the mouse pointer was on during the right-click is actually offered for deletion.

The Delete All is a bit more hazardous since if the user doesn't pause and fully take in the words in the pop-up notice, they might be thrown by all their pools being deleted rather than just the highlighted ones. Also, the video shows the unexpected "config journal unavailable after 10 attempts" error from the backend during this operation. I'm not sure if this is a sign that the frontend is hitting the API in a bad way or if it's a backend bug, but also seems worth looking closer at.

Of course, I expect we could make this all go away by just not allowing for multi-select on the pools list, which might be the expedient route. 😄

https://user-images.githubusercontent.com/5934157/191823583-7076b7e4-f06f-4296-90ff-775f08758edb.mp4

philrz avatar Sep 22 '22 18:09 philrz

Yup, that's no good

jameskerr avatar Sep 22 '22 20:09 jameskerr