zui icon indicating copy to clipboard operation
zui copied to clipboard

Published 20 hours ago • verified publisher icon brimdata

Allow app to have no tabs open

Open jameskerr opened this issue 2 years ago • 2 comments

Let's be more like vscode than google chrome. Since our sidebar offers alot of navigation, let's allow a state where there are no tabs open. The user can still click pools and queries in the sidebar.

jameskerr avatar Mar 05 '22 00:03 jameskerr

@jameskerr did you have an empty state in mind to fill the main page in this tabless scenario?

mason-fish avatar Mar 31 '22 15:03 mason-fish

I just took a swing at this and missed. Here are my thoughts for the next attempt.

Much of the app depends on a tab being active. We'd need the whole sidebar and app wrapper components to have no dependencies on state from the "active tab".

jameskerr avatar Sep 06 '22 18:09 jameskerr

Verified in Zui commit 05f017b.

The linked PR #2797 changed more than just allowing for the app to have no tabs open. Now each window will only be able to connect to one lake at a time, so as shown in the attached video, changing the lake connection in the drop-down menu changes the tabs shown to the ones previously established when connected to that lake. The video also shows how the app does indeed now allow all tabs to be closed. When in that "no tabs" state, currently just the big Zed logo background image is shown in the large/blank area, so #2804 has been opened to remind us to put something more helpful there eventually.

https://github.com/brimdata/zui/assets/5934157/e91e3f88-c459-4bc6-8db5-12748fd85c37

Thanks @jameskerr!

philrz avatar Jul 18 '23 18:07 philrz