zed icon indicating copy to clipboard operation
zed copied to clipboard

"zed delete" doesn't create a detailed log message

Open philrz opened this issue 3 years ago • 0 comments

Repro is with Zed commit cdd9d06.

Other commands like load and revert include details in the log, whereas delete just shows the commit ID. Not sure how detailed we'd want to get, but at minimum it seems it would be helpful to mention it was a delete, and perhaps also the object IDs, or deleted record count & -where filter if applicable.

$ zed -version
Version: v1.2.0-73-gcdd9d063

$ curl http://localhost:9867/version
{"version":"v1.2.0-73-gcdd9d063"}

$ zed create foo
pool created: foo 2Fj9ovuwi3N6idrBlJjvkLYkpyA

$ zed use foo
Switched to branch "main" on pool "foo"

$ zed load sample.zng 
(2/1) 4910B/4910B 4910B/s 100.00%
2Fj9pdCUsAq4GOwOaGwWbsRo4Ao committed

$ zed log
commit 2Fj9pdCUsAq4GOwOaGwWbsRo4Ao (HEAD -> main)
Author: [email protected]
Date:   2022-10-05T18:33:29Z

    loaded 1 data object

    2Fj9pZCcqd0SswbeUXYyOhwTFqy 31 records in 4821 data bytes

$ zed delete 2Fj9pZCcqd0SswbeUXYyOhwTFqy
2Fj9rHNh1Q1zauydfqrgqK2gSET delete committed

$ zed revert 2Fj9rHNh1Q1zauydfqrgqK2gSET
"main": 2Fj9rHNh1Q1zauydfqrgqK2gSET reverted in 2Fj9sOtzwuIMebgM1rH9JM4lczd

$ zed log
commit 2Fj9sOtzwuIMebgM1rH9JM4lczd (HEAD -> main)
Author: [email protected]
Date:   2022-10-05T18:33:51Z

    reverted commit 2Fj9rHNh1Q1zauydfqrgqK2gSET

commit 2Fj9rHNh1Q1zauydfqrgqK2gSET
Author: [email protected]
Date:   2022-10-05T18:33:42Z

commit 2Fj9pdCUsAq4GOwOaGwWbsRo4Ao
Author: [email protected]
Date:   2022-10-05T18:33:29Z

    loaded 1 data object

    2Fj9pZCcqd0SswbeUXYyOhwTFqy 31 records in 4821 data bytes

philrz avatar Oct 05 '22 18:10 philrz