zed icon indicating copy to clipboard operation
zed copied to clipboard

handle multiple pool keys

Open mccanne opened this issue 4 years ago • 5 comments

e.g., primary, second etc keys should be allowed for pools. The data structures are all set up for this but the compiler and optimizer currently assume a single primary key.

Also, dag.Merge will need to handle multiple keys and dag.Merge.Reverse + Key should be replaced with order.Layout.

mccanne avatar May 03 '21 17:05 mccanne

@mccanne senses he may be able to knock this one out quickly shortly after he addresses #2482, but if this turns out to be harder than we thought, we agreed that we can push it out to MVP1.

philrz avatar May 06 '21 22:05 philrz

Note to self: When this gets implemented, remove the reference to this issue from the Zed lake design doc.

philrz avatar Aug 20 '21 20:08 philrz

optimizer needs to handle multi-sort keys too

mccanne avatar Apr 21 '23 17:04 mccanne

We discussed this one again recently and figured we could continue postponing implementation until we have more traction with the lake. But in the short term we should have the tooling prevent the configuration of multiple pool keys and kick back a message referencing this issue so we can find out if there's demand from users that need it. (#4596)

philrz avatar Nov 07 '23 16:11 philrz

I've been told that the work in #5851 and related PRs lay the groundwork for us eventually being able to do this in the lake.

philrz avatar Apr 28 '25 00:04 philrz