goldpage icon indicating copy to clipboard operation
goldpage copied to clipboard

Goldpage does not work on windows

Open estyrke opened this issue 4 years ago • 10 comments

When running goldpage build (or goldpage dev) on windows, an internal error occurs (unfortunately I don't have a windows box to try on now, but the error is very terse anyway). It seems related to the assumption that paths are separated by forward slashes, which is not the case on windows.

estyrke avatar Apr 29 '20 10:04 estyrke

That's possible. I don't have a windows box right now but I'll have a look at it later.

brillout avatar May 01 '20 11:05 brillout

Goldpage doesn't support Windows for now. Comment this ticket if you want windows support.

brillout avatar Oct 01 '20 10:10 brillout

I'm doing a bit of research and discovered Goldpage, love its focus on do-one-thing-do-it-well! Knowing my team works primarily on Windows (I'm on MacOS), we might give Goldpage a spin with WSL but this would be a non-starter for us.

Assuming this issue may one day be closed as "Won't Fix", it'd be great if there was a note in the README with platform support.

It seems related to the assumption that paths are separated by forward slashes, which is not the case on windows.

This tickles my curiosity but I'm not on Windows. I wonder if path.join() or cross-env (now in maintenance, alternatives include env-cmd or @naholyr/cross-env) could help.

littleninja avatar Jan 12 '21 00:01 littleninja

Hi @littleninja !

I will have another look and tentatively write a patch.

brillout avatar Jan 12 '21 19:01 brillout

I'll write a patch tentivally next week. In the meantime, WSL should work.

brillout avatar Jan 14 '21 08:01 brillout

@littleninja Still interested? I've capacity today to write the patch.

brillout avatar Jan 19 '21 08:01 brillout

Sorry for the delay, I hope my comment didn't come across in a way that shifted priorities. There's no urgency on my part. 😔

littleninja avatar Jan 21 '21 01:01 littleninja

No worries.

There's no urgency

You may wanna wait on https://github.com/reframejs/goldpage/issues/24 then. It's going to be lovely.

If you don't mind me asking; what exactly are your plans with Goldpage? We can discuss in depth about whether Goldpage is/will be a good fit for you, and it's insightful for me to talk about my users' use cases.

brillout avatar Jan 21 '21 08:01 brillout

@littleninja FYI https://github.com/brillout/vite-plugin-ssr

brillout avatar Feb 16 '21 19:02 brillout

@littleninja https://github.com/brillout/vite-plugin-ssr is pretty much done and I published a beta. I'd be curious to know what you think.

brillout avatar Feb 28 '21 09:02 brillout