Rom

Results 727 comments of Rom

There is work in progress for a deep integration between vite-plugin-ssr and Vue Router. Something similar could be done for React Router. Maybe we could consider rebasing Nostalgie on https://github.com/brillout/vite-plugin-ssr....

I don't need this for now but I'll keep this open if I need this in the future. Thanks!

Implemented a prototype that automatically deploys a full-stack app (including database, auto backup, letsencrypt, etc.). The tool uses but fully abstracts(!) Nix.

Vite-plugin-ssr doesn't do anything with `public/` assets, so it's likely a Vite issue during SSR building.

It seems that `@vitejs/plugin-vue` tries to resolve `src` if it doesn't match a `public/` asset. Vite-plugin-ssr 0.4 changed Vite's config `publicDir` to `false` for SSR, which explains the problem. I...

> The proper fix would be to stop separating the client-side and server-side building process into two isolated processes. FYI, this is one of many reasons why I believe the...

Yes, to avoid the public directory being copied twice at `dist/client/assets/` and `dist/server/assets/`. If the user has a couple of gigabytes of images, that's significant.

The reason for `'mpa'` was to avoid setting `single: true` for `sirv()`, which this PR preserves. I unfortunately don't have the bandwidth to implement a test case. I found a...

`indexHtmlMiddleware()` only serves URLs ending with `.html`: https://github.com/vitejs/vite/blob/cc8800a8e7613961144a567f4024b71f218224f8/packages/vite/src/node/server/middlewares/indexHtml.ts#L291 While `spaFallbackMiddleware()` appends `'.html'` to URLs: https://github.com/vitejs/vite/blob/cc8800a8e7613961144a567f4024b71f218224f8/packages/vite/src/node/server/middlewares/spaFallback.ts#L17-L24 In other words: > Fix `appType: 'mpa'` which currently doesn't work: `indexHtmlMiddleware()` doesn't work without...

> I do agree that a proper fix would be to split out `spaFallackMiddleware()` in two middlewares (one that appends `.html` and a second one that does the SPA fallback)....