docker-osx-dev icon indicating copy to clipboard operation
docker-osx-dev copied to clipboard

Published 20 hours ago • verified publisher icon brikis98

Brew Cask dependency shouldn't break installation

Open ain opened this issue 9 years ago • 7 comments

If Brew Cask isn't used on any of the dependencies, it shouldn't be a breaking dependency?

ain avatar Nov 22 '15 18:11 ain

Hm... It used to be a requirement to install VirtualBox. However, at some point, the brew_install call for VirtualBox disappeared. Is it installed by something else?

brikis98 avatar Nov 23 '15 03:11 brikis98

VirtualBox was removed in 56edcdbe3f65d3c23677ca7dbacbdc5678047ecd by PR #55.

Generally, VirtualBox is also part of Docker Toolbox that delivers most of the dependencies.

ain avatar Nov 23 '15 22:11 ain

@tsupertramp was there a particular reason why you removed VirtualBox from the dependencies?

I'd actually rather have it in there as we have everything else. The original implementation does make sense.

ain avatar Nov 23 '15 22:11 ain

Considering the feedback from other topics, Brew Cask dependency should be restored.

ain avatar Dec 09 '15 12:12 ain

@ain @brikis98 what's the verdict here re: VirtualBox as a dependency? The project README only lists Homebrew as a prerequisite. We should either add VirtualBox/Docker Toolbox there or add VirtualBox back to the brew dependencies.

ejones avatar Jan 25 '16 22:01 ejones

Usually, the goal is to put as little into docker-osx-dev as possible. If docker-toolbox installs most of what we need, we should use that, let it handle the details, and remove the rest.

brikis98 avatar Jan 26 '16 01:01 brikis98

I agree with @brikis98 since Docker Toolbox delivers:

  • Docker Engine
  • Docker Machine
  • Docker Compose

I'd propose removing all functions that try to install them and have a dedicated Requirements section in README instead.

VirtualBox should just make a separate bullet point in README.

ain avatar Feb 10 '16 14:02 ain