monaco-vim Only import the editor API instead of the whole package so that Webpack only loads relevant code

When you import directly from monaco-editor webpack will pull in the entire monaco package, including all supported languages. It is recommended to import from monaco-editor/esm/vs/editor/editor.api instead.

See: https://github.com/microsoft/monaco-editor-webpack-plugin/issues/43 for more information

Jul 31 '20 21:07 apmorton

This is something that you can control using webpack resolver or babel where monaco-editor can be aliased to the api file.

Aug 01 '20 04:08 brijeshb42

maybe, but thats a silly workaround to expect of users when usage of the monaco esm is implied on the immediately following line: https://github.com/brijeshb42/monaco-vim/blob/master/src/cm_adapter.js#L13

The definitively correct thing to be doing here is importing only the monaco API, and let the user pull in the full monaco package if desired in their own code.

Aug 01 '20 05:08 apmorton

You'll also need to update the webpack config so that the umd build works as well.

Aug 01 '20 05:08 brijeshb42

does this look correct to you?

'monaco-editor/esm/vs/editor/editor.api': {
    root: 'monaco',
    commonjs: 'monaco-editor/esm/vs/editor/editor.api',
    commonjs2: 'monaco-editor/esm/vs/editor/editor.api',
    amd: 'vs/editor/editor.api',
},

Aug 01 '20 06:08 apmorton

AMD version should be what it is currently. It doesn't have api file.

Aug 01 '20 06:08 brijeshb42

Can this issue be resolved? Currently my monaco-vim is bundling all the language files when it doesn't need to be and this seems like it should be good to go.

Apr 24 '23 02:04 terryzfeng

This PR can be closed as of the latest update

Sep 15 '23 22:09 terryzfeng