medium-draft icon indicating copy to clipboard operation
medium-draft copied to clipboard

Published 20 hours ago • verified publisher icon brijeshb42

+ side button doesn't go to the new line when insert embed video

Open Andresmag opened this issue 7 years ago • 4 comments

captura de pantalla 2018-02-12 a las 16 49 30

So as you can see in the image above, the + button remains at the top of the video when you insert it instead of going down to the new line where it should be. This image is taken from the demo example in the repository so I suppose this is a bug to fix.

Do you have any idea about how to solve it? Or are you already working on it?

Congratulations for the great job you're doing! :)

Andresmag avatar Feb 12 '18 15:02 Andresmag

This is a known issue. This occurs because as the embed loads, it's height change is not noticed by the button and it remains at its position. If you press enter again the button will change position correctly. Will have to have a workaround to fix this issue.

brijeshb42 avatar Feb 13 '18 04:02 brijeshb42

Ok, perfect. But I've just noticed that the demo do something strange in Chrome, when you click the + button, the view goes to the top of the page losing where it was. Did you know anything about it?

Andresmag avatar Feb 13 '18 18:02 Andresmag

+1 Is there any way I can prod the button to update programmatically? I receive the an event once the video is fully loaded so I could just launch a callback which could trigger the button position update. Is there anything in place that could let me do that?

d-baranowski avatar Sep 14 '18 11:09 d-baranowski

@d-baranowski You can call foreUpdate method of your component to rerender.

brijeshb42 avatar Oct 20 '18 05:10 brijeshb42