Decryption seems to be broken.

[David112x]

As the title states, I have tested the TWRP build that was released by GitHub Actions here in this repo and decryption doesn't work on that, ~~it only works on the build from November 7th meaning that something broke shortly after that build, seeing as how a build from November 25th didn't have working decryption~~, although in this issue we can see a build that's different from the one released in November 7th, which does have working decryption, seeing as how the size of the Internal Storage partition is being reported while it wouldn't if decryption wasn't working (it would simply display 0MB if it didn't work).

I've been attempting to get my own OrangeFox build and while I was able to fix the padding and such, I wasn't able to fix decryption and I'm still looking into it, though I find it very likely that something broke in TWRP and that the tree now has to account for.

I tried reverting a few things in the tree itself to how they were at the time of the build from November 7th and that didn't do it.

Update: It would seem that decryption was always broken on the official sources or had been since last year, still no idea on how to get it to work.

[David112x]

~~After reading through the issues in this repo (mainly this one), it looks like we were never actually using official sources and if that isn't the case then.~~

EDIT: I'm confused on whether we were or weren't using official sources, this issue does shed some light into the whole situation but it's from last year, not entirely sure if it's the case to this day.

How can I get OrangeFox to work with decryption support, I mean I've looked into the build scripts for GitHub Actions and there wasn't anything that caught my attention, aside from the "for test mount sd" commit which seemed to make repo use a different fscrypt for TWRP but I can't really figure out how to do that for OrangeFox and there's already 2 builds that should already be using that "different fscrypt" such as the latest one released from GitHub Actions and the one that was released in my fork, neither of those had working decryption so I don't what the deal is there.

[David112x]

Well, it seems I was mistaken, there's a big chance that the decryption issue was going to be tested with a different fscrypt to see if this commit fixed it and if that's the case then it means that there's no fix for this yet, because even after that commit, decryption is still not working and so far it doesn't look like there's a fix.