Code signing script needs update

[OskarGroth]

Not using this software, but ran into the same problem and thought I'd drop a hint.

The CodeSigningUpdate (https://github.com/brightdigit/Speculid/blob/12ef69622a6940f75201f4767566a79345146ff2/scripts/CodeSignUpdate.sh) script is failing on Xcode 11 because Mac Developer certificates are now on the form Apple Development: instead of Mac Developer:.

You incorrectly fixed this by commenting out set https://github.com/brightdigit/Speculid/commit/36ff4be8f9e17caae7e0946a1d3e5275b209c2c8#diff-de6b762ded769596e652fd6f22b5e3af which causes the script to finish despite the errors, but the error still occur and as a result your Info.plist is borked: https://github.com/brightdigit/Speculid/blob/36ff4be8f9e17caae7e0946a1d3e5275b209c2c8/applications/mac/Info.plist#L36

Instead, the error can be fixed correctly by updating the scripts macDeveloper function as follows:

if ! [[ ${macDeveloperCN} =~ ^Apple\ Development:\ .*\ \([A-Z0-9]{10}\)$ ]]; then
    printf "%s\n" "Invalid Mac Developer CN: ${macDeveloperCN}"
    exit 1
fi

[leogdion]

Thanks @OskarGroth I'll look into this.

[leogdion]

@OskarGroth I am still having issues with this even after changing the script. Not sure if it's still the same issue. https://travis-ci.org/brightdigit/Speculid/builds/640931671