Frankie Bagnardi

Results 56 comments of Frankie Bagnardi

Thanks for reporting this. Sorry for the delay, fixed in 5.1.3. New behavior: Input: ``` var React = require('react'); type Props = { foo: string | void, }; function C(props:...

@nvie it seems we don't support `type X` at all. I don't have time to implement it, but I'd love a PR.

Yeah, we don't have a list of global types. So, currently the solution is: ```js const Element = window.Element; type FooProps = { element: Element, } class Foo extends React.Component...

Thanks for the report. What would the expected behavior be here? What code should we generate?

Hey, this is expected behavior of [the plugin][1], but since `bpfrpt_proptype_WindowScroller` isn't used anywhere, we'd ideally remove it. However, this requires some form of escape-analysis, which is a bit tricky....

IE6 and 7 have a limited practical lifetime. Next April, XP support will be dropped. As soon as someone creates an attack not already patched for, companies will be forced...

@Topener, someone wrote a plugin that does this. It's basically mbest's code wrapped in an extender (can't find it right now). Alternatively: ``` js // source: http://stackoverflow.com/a/18184016/1074592 ko.subscribable.fn.subscribeChanged = function...

It seems like this will call factory twice. If you look at this part, and assume the the if statement will evaluate to true... ``` javascript if (typeof define ===...

Without the metro-react-native preset, I get this as babel output, which looks good: ```js import api from "../../services/api"; ``` and with it, I get this, which also appears to be...