checkov icon indicating copy to clipboard operation
checkov copied to clipboard

fix(terraform): CKV_AWS_339 - Update supported EKS platform versions

Open omnibrian opened this issue 5 months ago • 5 comments

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Update list of supported EKS platform versions to remove versions that are no longer receiving extended support (1.25, 1.26, and 1.27) and add new available versions.

Fixes #7373

New/Edited policies (Delete if not relevant)

  • CKV_AWS_339

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my feature, policy, or fix is effective and works
  • [x] New and existing tests pass locally with my changes

omnibrian avatar Jul 21 '25 20:07 omnibrian

~Looking at the open PRs, I do see one that is trying to add 1.33 to the EKS platform versions already but is over a month old. Let me know if you'd rather just include that and I can close this PR.~

Edit: Looks like adding 1.33 has been merged into main, edited to just be removing the older unsupported versions of EKS

omnibrian avatar Jul 21 '25 20:07 omnibrian

It looks like 1.27 has been dropped for extended support now too, included that removal in the change set

omnibrian avatar Aug 07 '25 15:08 omnibrian

Hey @omnibrian, Could you please fix the failing tests? Thanks for the contribution!

MaryArmaly avatar Aug 20 '25 14:08 MaryArmaly

Hey @MaryArmaly, I wasn't able to reproduce the issue locally and the test doesn't seem to have any relation to the EKSPlatformVersion files I've touched. I just rebased changes against the latest in main in case it was an issue based on the point in time of main my changes were based on

omnibrian avatar Aug 20 '25 14:08 omnibrian

Adding 1.34 since that's now been released as an EKS platform version. Also rebased on the latest in main.

I'm not sure if there's something in here that's stopping a review from happening, but it feels like this might be slipping through the cracks. @MaryArmaly or @bo156 or @achiar99 do any of you know if there's something I'm missing or someone I should reach out to?

I tried logging into the slack linked in README.md since CONTRIBUTING.md mentions asking for help in the slack but it looks like there's no way to sign up as an external contributor.

omnibrian avatar Nov 24 '25 18:11 omnibrian