checkov icon indicating copy to clipboard operation
checkov copied to clipboard

fix(terraform): Ignored `--external-modules-download-path` flag

Open apgrucza opened this issue 1 year ago • 4 comments

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fixes a bug where --external-modules-download-path is ignored.

Fixes #6675

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my feature, policy, or fix is effective and works
  • [x] New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Implements the --external-modules-download-path flag functionality in the Terraform plan runner. Modifies the RunnerRegistry and TFParser classes to accept and use the external modules download path parameter. Adds a test case to verify the correct usage of the new parameter.

Latest Contributors(2)
UserCommitDate
lirshindalmanfix-terraform_plan-run...December 01, 2024
[email protected]feat-arm-unsupported-m...October 15, 2024
This pull request is reviewed by Baz. Join @apgrucza and the rest of your team on (Baz).

apgrucza avatar Aug 22 '24 04:08 apgrucza

Hey @apgrucza, Thanks for the contribution! Could you please merge the latest changes from the main branch into your branch? Thanks!

MaryArmaly avatar Jan 15 '25 08:01 MaryArmaly

Sorry for the delay @MaryArmaly, I've now rebased with the latest changes from main

apgrucza avatar Feb 28 '25 05:02 apgrucza

@apgrucza Can we look at reviving this pull request? I would really like to see this error get fixed

Guitrum avatar May 07 '25 18:05 Guitrum

Still waiting for it to be merged @Guitrum. I've rebased again to resolve conflicts. @MaryArmaly can we get this merged now?

apgrucza avatar May 19 '25 00:05 apgrucza

I've updated the branch & run tests.

pazbechor avatar Aug 10 '25 10:08 pazbechor

Hey @apgrucza, Since all the tests have passed and there are no conflicts with the main branch, I've merged this PR. Thanks for contributing!

MaryArmaly avatar Aug 20 '25 13:08 MaryArmaly