checkov icon indicating copy to clipboard operation
checkov copied to clipboard

fix(terraform): fix false positives for CKV_GCP_49

Open saisirishreddy opened this issue 1 year ago • 1 comments

User description

Below predefined roles do not include service account impersonate permissions.

roles/dataproc.editor roles/dataproc.admin roles/dataflow.developer

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my feature, policy, or fix is effective and works
  • [x] New and existing tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

Generated description

Dear maintainer, below is a concise technical summary of the changes proposed in this PR:

Remove incorrect role assignments from AbsGoogleImpersonationRoles to prevent false positives in CKV_GCP_49 checks.

TopicDetails
Role Correction Remove incorrect role assignments from AbsGoogleImpersonationRoles to prevent false positives in CKV_GCP_49 checks.
Modified files (1)
  • checkov/terraform/checks/resource/gcp/AbsGoogleImpersonationRoles.py
Latest Contributors(2)
EmailCommitDate
28880387+tsmithv11@use...fix-terraform-Remove-d...September 19, 2024
86768411+YaaraVerner@u...Add-evaluated-keys-for...September 26, 2021
This pull request is reviewed by Baz. Join @saisirishreddy and the rest of your team on (Baz).

saisirishreddy avatar Mar 19 '24 18:03 saisirishreddy

Hey @saisirishreddy, thanks for the contribution! I see some checks failed, could you please resolve the issues?

MaryArmaly avatar Aug 06 '24 06:08 MaryArmaly