BitCrack icon indicating copy to clipboard operation
BitCrack copied to clipboard

Address.fromPublicKey is returning wrong address

Open wisammechano opened this issue 3 months ago • 0 comments

In random testing of this tool, I found out that it generated the wrong address for the following:

public key: 02b9e58a925566151f0c168980b36b4c5815c0b85f226f590d16a00467e0b037da hash160: 00b3fed5f2135a0f3f6ac65e67ecf3b0239d9cfb generated address: 14idJbAR6gZ8A5zMqTHF28RxU8w2DE9ui expected address: 114idJbAR6gZ8A5zMqTHF28RxU8w2DE9ui

I believe the generated address is not padding with 1 when the first byte in the hash is 00.

Thankfully, this doesn't affect the search algorithm as it compares hash160 to hash160 but it is worth noting that anywhere the Address.fromPublicKey() function is used, it can potentially display a wrong address.

wisammechano avatar Nov 04 '24 03:11 wisammechano