react-babylonjs icon indicating copy to clipboard operation
react-babylonjs copied to clipboard

Observables Strong Typing

Open dennemark opened this issue 3 years ago • 0 comments

As mentioned in a discussion, this issue should keep track of adding stronger typings to observables.

Original discussion:

Is my assumption right, that observables are updated properly?

https://github.com/brianzinn/react-babylonjs/blob/daa6605d1702f282365d797a7b1ab3bc0cb89db8/packages/react-babylonjs/src/UpdateInstance.ts#L54

When writing it as property, it is missing proper typing though. Would this be easy to solve? Image shows typing when getting pointerDragBehaviour via create and the missing types when it is set as prop.

image

Originally posted by @dennemark in https://github.com/brianzinn/react-babylonjs/discussions/255

dennemark avatar Nov 11 '22 08:11 dennemark