Brian Voelker comments

Results 137 comments of


                                            Brian Voelker

Add tests

looks good to me. carry on sir.

Clear button does not work when data is fetched by Ajax

https://codepen.io/brianvoe/pen/MWXqXXV Can you recreate a running example please

Clear button does not work when data is fetched by Ajax

I believe you I just havent fixed it yet. feel free to submit a pr.

Replace css animation with js animation

https://github.com/brianvoe/slim-select/issues/359

Replace css animation with js animation

I think i follow you on a few of these. I have noticed i need to address multiple afterChange calls and a few other things. I cant tackle this today,...

Replace css animation with js animation

Yep i do see that. If you already found the spot your more then welcome to do a pr. Otherwise Ill try to get to it in the next few...

Replace css animation with js animation

Totally fine. I think I am going to try out debouncing the event callback. Instead of trying to pinpoint where to allow the callback.

Replace css animation with js animation

I honestly might have to change it all to js animations but who knows when ill be able to do that

Replace css animation with js animation

im open to pr's if you want to submit something.

Flickering dropdown when toggling it

I dont see any flickering in your video.