Brian Scholer

[WIP] Add `AdapterResponse` types, and `HvacAdapter`

1

Closes #797 Closes #293 Closes #385 Closes #660 This started after discussion about how we might handle 204 responses better in the `JSONAdapter` (see also #847), but led to us...

"Multi-line [single|double]-quoted string needs to be sufficiently indented" with inline Jinja

2

### Summary I often split long Jinja expressions over multiple lines, like so: ```yaml var: '{{ "123" | int }}' ``` But the extension is marking them as an error,...

**Is your feature request related to a problem? Please describe.** When using the vault container to run agent, along with `VAULT_LOCAL_CONFIG`, the entrypoint does write the config file to the...

ansible-test sanity - please skip `files/` and `templates/` in collection roles and playbooks by default

12

### Summary When running sanity tests against a collection with roles, files in the `files/` and `templates/` directories are also scanned, which often is not the right behavior. For example,...

Integration tests can't be run on Windows

7

As reported here: - https://github.com/hvac/hvac/pull/1006#issuecomment-1595876686 It seems like there's an issue with the way the test Vault server is launched from the test suite, related to I/O redirection. Since we...

Add support for Login MFA

1

The newer MFA style supported in Vault since v1.10.0 requires changes to use with `hvac` and we don't support it right now. It supports both a one-phase and (more commonly)...

Integration test intermittent failures

2

Example: - https://github.com/hvac/hvac/actions/runs/6249510353/job/16966329531?pr=1062#step:8:172 - https://github.com/hvac/hvac/actions/runs/6517739025/job/17702941928?pr=1072#step:8:122 - https://github.com/hvac/hvac/actions/runs/6519522650/job/17706109258?pr=1087#step:8:111 - https://github.com/hvac/hvac/actions/runs/6696342161/job/18193886750#step:8:112 These come up from time to time, and typically re-running the tests works fine. The issue seems to be that the...

Right now there's no exception type for 412 status codes that get returned for eventual consistency failures, so we return `UnexpectedError` which is not very helpful on its own. https://github.com/hvac/hvac/blob/8829ff20840743f89a90ec4319e8974fade18cd7/hvac/exceptions.py#L21...

Is HVAC unable to verify a re-key operation with the recovery_key=True flag?

1

### Discussed in https://github.com/hvac/hvac/discussions/1094 Originally posted by **Ar-personal** October 17, 2023 The HVAC code usually swaps out the api path for re-key operations from api_path = "/v1/sys/rekey/" to api_path =...

Implement the breaking changes in: - https://github.com/hvac/hvac/pull/1063