Results 341 comments of Brian Scholer

Welcome @ahamilto and thanks for opening this PR! Special thanks for adding test coverage, I really appreciate it! I've added a comment in the original issue looking to understand the...

btw I cancelled the integration test runs, they all appeared to be stuck and I'm unsure why yet (or whether it's even related to this change 🤔)

> @briantist thank you for the welcome. I am looking to get more involved in HVAC maintenance since it is a library that my company uses heavily and I am...

> I don't want to be prescriptive on that alternative library so we don't need to add it to the tests, but definitely open on doing a pseudo-check ("necessary characteristics")...

I'll throw another concrete example of where I'm running into this and where some way of breaking the cycle would be helpful. I'm using the [ACME provider](https://registry.terraform.io/providers/vancluever/acme/latest/docs). The [`acme_registration`](https://registry.terraform.io/providers/vancluever/acme/latest/docs/resources/registration) resource...

@apparentlymart first off, thanks so much for your thorough and detailed reply! > I think "replace this if this other thing is going to be created" could be a more...

I would like to ask what the impact of this bug is. As in: * what is the behavior if a non-Session object (like a dict) is passed in? *...

Thanks @surfer190 that makes sense, thank you for the info! I'll re-open this especially as there's an open PR intended to address it

I don't see it in your example so just wondering if you tried the [`ca_cert` option](https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/hashi_vault_lookup.html#parameter-ca_cert)? As mentioned in the doc you can also set the `ANSIBLE_HASHI_VAULT_CA_CERT` environment variable, or...

hm, I think the documentation for that parameter is wrong. That description goes all the way back to when this plugin was part of ansible (before collections existed), for example:...