ring icon indicating copy to clipboard operation
ring copied to clipboard

support for RISCV32

Open ub-tech opened this issue 1 year ago • 2 comments

Hi - I'm trying to run a repo with ring as dependency on a RISC32 arch. I tried to override the dependency based on this convo. Is riscv32 supported? Am I trying to implement this override correctly (please see below)? TY very much for any insights.

[patch.crates-io] ring = { git = "https://github.com/leso-kn/ring.git", package = "ring", branch = "riscv64-support-plus-riscv32" }

ub-tech avatar Apr 30 '24 16:04 ub-tech

In target.h, we have:

#elif defined(__riscv) && __SIZEOF_POINTER__ == 8
#define OPENSSL_64_BIT

So presumably we would also need to add the corresponding change for riscv32.

The bigger issue, AFAICT, is that we don't have any way of testing riscv32 code in CI.

briansmith avatar May 07 '24 00:05 briansmith

See https://github.com/briansmith/ring/pull/2042#issuecomment-2120898907 for an alternative approach.

briansmith avatar May 21 '24 06:05 briansmith

Please check out PR #2082 to see if this works for you.

briansmith avatar May 27 '24 19:05 briansmith

Closing this on the assumption that PR #2082 resolves this, at least if you're not using an old version of GCC>

briansmith avatar Jun 05 '24 18:06 briansmith