ring icon indicating copy to clipboard operation
ring copied to clipboard

Add Apple visionOS support

Open QuentinPerez opened this issue 1 year ago • 5 comments
trafficstars

Motivation

Add the support of Apple VisionOS 121419

Solution

Add target_os = "visionos"

QuentinPerez avatar Apr 16 '24 14:04 QuentinPerez

Thank you for the review. It's clearer now how ring works. The change is much simpler! And yes, I tested it; the app is even on the App Store :) .

QuentinPerez avatar Apr 25 '24 11:04 QuentinPerez

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.35%. Comparing base (be4ba83) to head (193bb7c). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   97.24%   97.35%   +0.10%     
==========================================
  Files         144      142       -2     
  Lines       19998    19915      -83     
  Branches      228      228              
==========================================
- Hits        19447    19388      -59     
+ Misses        525      500      -25     
- Partials       26       27       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 25 '24 16:04 codecov[bot]

Hello! I'm curious if this same change would be required to add support for watchos.

sax avatar Apr 27 '24 19:04 sax

@QuentinPerez could you please rebase this on top of the latest changes on the main branch. The recent changes should result in it being even simpler now.

briansmith avatar May 07 '24 00:05 briansmith

Hello! I'm curious if this same change would be required to add support for watchos.

There are several watchos targets, some of which are easier to support than others. PR #1914 started to add support for watchOS, but it got closed before it was finished. I suggest you pick where that left off.

briansmith avatar May 07 '24 00:05 briansmith

Closing in favor of #2112 and #2113. Please see those PRs for important details. I would appreciate testing of them and feedback, especially related to performance and code size.

briansmith avatar Jun 20 '24 22:06 briansmith