sorting-network icon indicating copy to clipboard operation
sorting-network copied to clipboard

Layers/depth seem non-optimal

Open henkjan-sneller opened this issue 2 years ago • 4 comments

While plotting a machine generated network I noticed that the order of nodes matters (for the layer assignment) while it should not AFAICT.

For example 2:5,0:1,4:5,0:3 yields: exampleNet

While 2:5,4:5,0:1,0:3 yields: exampleNet and I expected it to be the same as the previous one since the layers and dephts did not change.

Q: is this a bug or a feature?

henkjan-sneller avatar Feb 22 '23 12:02 henkjan-sneller

Yes, this is a bug.

It needs some code to "collapse" the network so that there are no unnecessary gaps at any given depth.

brianpursley avatar Apr 25 '24 21:04 brianpursley

@henkjan-sneller Thanks for reporting this. It should be fixed by a change I just made.

brianpursley avatar Apr 26 '24 00:04 brianpursley

Thanx!

HJLebbink avatar Apr 26 '24 08:04 HJLebbink

The optimal depth grouping has been fixed, but it seems within a single depth, the comparators are still not organized as well as they could be.

Screenshot_20240506-184655

So maybe there is still some work that can be done to improve this.

brianpursley avatar May 06 '24 22:05 brianpursley