Brian Pursley

Results 83 comments of Brian Pursley

> Should username be deprecated as well as password mentioned in the issue. Since auth will need to be done with token. username will cause an error or be set...

I haven't been following this issue, but since I'm mentioned a couple times because of my original comment on another PR that prompted this, I want to add some points...

My only concern is whether users need to know that a finalizer is pending, but "Terminating" status doesn't distinguish between waiting for containers to exit and waiting for finalizers to...

@wangli1030 are you thinking something like this? https://github.com/kubernetes/kubernetes/pull/124489 Regardless, it seems wrong that `NewWarningWriter` is exported, but its return type, `warningWriter` is not: https://github.com/kubernetes/kubernetes/blob/a9593d634c6a053848413e600dadbf974627515f/staging/src/k8s.io/client-go/rest/warnings.go#L94

I did some research on this and found something interesting. Kubectl uses something called ["Natural Sorting"](https://github.com/fvbommel/sortorder/blob/a8d9302c17f9f46c6580b82b919672e58ef6e396/casefolded/natsort.go#L45-L62) to sort strings. https://github.com/kubernetes/kubernetes/blob/f4e246bc93ffb68b33ed67c7896c379efa4207e7/staging/src/k8s.io/kubectl/pkg/cmd/get/sorter.go#L272-L284 And this results in some unexpected results when sorting strings...