Brian Popow

Results 95 comments of Brian Popow

> Is this helpful (or am I out of my depth)? @shapeh: Thanks for looking into this, any help is always welcome! Just to give some context how tiff decoding...

@JimBobSquarePants I was looking a bit further into this. I still think we should map the colorspace to RGB in `TiffJpegSpectralConverter{TPixel}.cs` and then handle the conversion to CMYK in `CmykTiffColor{TPixel}.cs`....

> It does seem that there are rgba jpegs out there. > > https://stackoverflow.com/questions/6212897/can-i-use-libjpeg-to-read-jpegs-with-an-alpha-channel I was not able to get those jpeg files from the stackoverflow post. The links seem...

> I don't have an understanding yet of how jpeg compression in tiff works so I cannot tell you whether your plan is sound. TiffJpegSpectralConverter.GetJpegColorSpaceFromPhotometricInterpretation confuses me. Why does it...

> All my hack does (I think) is trick the decoder into actually doing something which allows following decoders to read the color space type. I think we should try...

I have started to work on this in the branch `bp/tiff-jpeg-cmyk`, this can decode a jpeg with cmyk (see the test `TiffDecoder_CanDecode_Cmyk`), but I was not yet able to figure...

The issue seems to be caused by frame 35, all previous frames can be decoded. Here is the frame with the issue: [frame35.zip](https://github.com/SixLabors/ImageSharp/files/14396315/frame35.zip) `webpinfo` does not report any issue with...

The issue seems to be in `HorizontalUnfilter` method of the AlphaDecoder and there in the SSE2 part.

@ynse01 The `Av1BitStreamReader` seems to work as it should, I was able to parse `Av1CodecConfiguration` with it d8e7078b. Maybe I can help with this PR, but I still in the...

> I fixed the bug :-) Tests are passing again. > > @brianpopow There are a few TODO items in the Heif container area, if you like you could have...