Carbon icon indicating copy to clipboard operation
Carbon copied to clipboard

Update SrLatnMeTest.php

Open perisicnikola37 opened this issue 2 years ago • 6 comments

perisicnikola37 avatar Jan 01 '23 21:01 perisicnikola37

Thanks. 🙏

Hello @milose @Glavic, invoking Serbian contributors 🧙 here to have a second look and if you can, please proceed the relevant changes on: https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Lang/sr_Latn_ME.php

kylekatarnls avatar Jan 01 '23 22:01 kylekatarnls

Looks good to me @kylekatarnls, thanks @perisicnikola37

milose avatar Jan 02 '23 10:01 milose

https://github.com/briannesbitt/Carbon/blob/1e60d1b9b3a445a6d450d960019a0a0c2f2a59d3/src/Carbon/Lang/sr_Latn_ME.php#L60 should be changed as per test to:

return '[prošlog ponedjeljka u] LT';

milose avatar Jan 02 '23 10:01 milose

@kylekatarnls Why this is still not merged?

perisicnikola37 avatar Mar 29 '24 12:03 perisicnikola37

Hello @perisicnikola37 this is only a test file, that does not actually change the actual translations which live in: https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Lang/sr.php

  • the variants Cyrl and Latn

So if I merge this alone, actually test won't pass anymore and it will have no effect for users.

It would need now to change accordingly all language files and tests (if there are other countries that ME that are concerned).

kylekatarnls avatar Mar 29 '24 13:03 kylekatarnls

I have another issue, I don't know why I cannot run the tests on this PR, maybe it needs to be rebased on last changes of master branch.

kylekatarnls avatar Mar 29 '24 13:03 kylekatarnls