mysql2 icon indicating copy to clipboard operation
mysql2 copied to clipboard

0.2.x update for ruby 2.5

Open pavelvasev opened this issue 4 years ago • 6 comments

Mysql2 0.2.24 does not compile in ruby 2.5 due to extra check this ruby performs on rb_funcall. In particular, file result.c had a bug - wrong number (6) of arguments on line 300.

  • This pull request fixes number of arguments to valid value of 7.
  • Also, to publish these change as a gem, a gem version is updated to 0.2.25.

I ask to merge this changeset in master repository and also ask to build and publish gem version 0.2.25.

pavelvasev avatar Jun 27 '20 12:06 pavelvasev

Anybody alive here?..

pavelvasev avatar Jul 04 '20 14:07 pavelvasev

Can you use a newer version of the gem to that supports current versions of Ruby?

The mysql2 0.2 series is rather out of date.

sodabrew avatar Jul 04 '20 17:07 sodabrew

Can you use a newer version of the gem to that supports current versions of Ruby?

The mysql2 0.2 series is rather out of date.

Thank you for your reply! I support Rails 2.3 application. We try to switch to Rails 2.3 LTS + Ruby 2.5, and it forces us to use mysql2. And as I understand, 0.2.x is the only branch compatible with ActiveRecord from Rails 2.3..

pavelvasev avatar Jul 04 '20 18:07 pavelvasev

What is Rails 2.3 LTS?

sodabrew avatar Jul 04 '20 18:07 sodabrew

What is Rails 2.3 LTS?

https://railslts.com/

pavelvasev avatar Jul 04 '20 18:07 pavelvasev

Here is their recommendation to use mysql2. https://makandracards.com/railslts/47192-ruby-2-5-support-for-rails-2-3-lts Actually they motivate it because mysql gem does not compile in ruby 2.5 at all.

pavelvasev avatar Jul 04 '20 18:07 pavelvasev