fast_xs
fast_xs copied to clipboard
brianmario
Implement JRuby support
This is a first approach to implement https://github.com/brianmario/fast_xs/issues/6
Please note that there is one test failing. Also please note that I haven't benchmarked the implementation yet. I'm open to suggestions what would be the best approach here.
Hey Charlie, not sure but I don't think so. Just thought as it was open for ~2 years now without much progress close it. There was also not much feedback from the maintainer, was there?
@ChrisBr Ahh ok, I understand.
Yeah, would still be nice to get this in, but perhaps @brianmario is not interested?
@brianmario Can we revisit this?
Hello!
Really sorry, I've fallen very behind on pretty much all of my OSS projects. Tbh I don't really have much time to code these days - I quit "tech" and am a grape farmer now 🧑🌾.
That said, I don't think I should need to hold this up any longer.
@headius 👋 I can go ahead and give you contrib access if you wouldn't mind taking it from here?
Seems like if nothing else the travis config should be updated to build on modern Ruby versions to get the builds happy(er). I don't think folks are still running on 1.8.7 anymore right?
@brianmario Sure, I can help get this integrated. Green CI would clearly be a first step. Maybe a separate PR to drop a few really old versions from CI?
Ping again... I missed an invite to collaborate, but it would still be nice to get JRuby support in here.
@headius hello again! The collaborator invite is still pending so you should be able to accept it still.