security-checklist
security-checklist copied to clipboard
brianlovin
Add language localization options.
In my opinion, enabling localization will help a lot of people to understand more. Since this is related to not only geeks but also normal users. It will be a good idea if we add it. Can I take this issue? If can I take it, may I know the checklist for making a pull request?
Let's do it! I've not worked through internationalizing a small app like this, so your help leading this would really be appreciated.
Perhaps we should add a call for translation help to README.md?
Could we start translating by copying config to something like config-ru|it|etc. dir even before someone with enough frontend knowledge does the coding?
https://github.com/isaachinman/next-i18next seems like the best place for us to start. Can poke around the code tonight or later this week.
https://github.com/isaachinman/next-i18next seems like the best place for us to start. Can poke around the code tonight or later this week.
please stub at least one translation sceleton (could be a copy-paste from English) so that we can follow up on that.
I'd be doing Russian version :)
Happy to help with a german localisation!
Just a quick note that localisation doesn't only mean translations but potentially also adapting links (e.g. of the telekom providers) and even replacing entire sections (the section on credit cards doesn't work this way in Germany at all I believe and would just confuse the readers).
Count me in for localization of strings in Persian! Also, I should point out that in some cases we may need to add or remove security tips from the main list, so it's not just translation
Is anyone working on setting up i18next? I'm happy to set it up so everyone can start contributing their translation 😸
@diego-codes I don't think anyone has started, but to the previous points we might want to think this through beyond just string translations, since some sections aren't applicable to countries outside of the US
I had started writing code. But I need some help @brianlovin. I followed according to documentation from https://github.com/isaachinman/next-i18next.
- I added
i18n.jsunderlib. (I also had to run npm update next due to this issue. https://github.com/isaachinman/next-i18next/issues/41) - Added changes to
pages/_app.js. - Added express and server.js
- Made changes to
pages/index.js.
What I had achieved is
<Heading>{this.props.t('be-safe-on-the-internet')}</Heading>.
But I was hading hard time how to use for config/data.js file. I am not sure whether I could pass pros or do sth.
I would love to know how would you recommed to do it? And what would you love to add for translation help to README.md?
@mgmgpyaesonewin could you push up a work in progress branch so I can see where you're at?
I should mention another thing about the multilingual feature: we need layout support for RTL languages such as Persian, Arabic, Hebrew
I started with the infrastructure work here: https://github.com/gnunicorn/security-checklist/tree/ben-i18n
It is set up to have separate namespaces for pages and components, can already toggle the language and update on the fly. Next up (but I am not sure when I have time for that):
- [ ] extract all inline text and put them into locale files
- [ ] extract all text from apps, make app-namespaces available
- [ ] add feature to flag data(-entry) to not-show/only-show in certain lang
- [ ] provide a proper language-toggle (currently detects browser)
If anyone wants to help work on this, let me know and I'll grant you access!
If anyone wants to help work on this, let me know and I'll grant you access!
I won't have time to help on this for a while, but if you add me I might try to dip in and out to help :)